Skip to content

adds --arch-dir argument to point to specific architecture directories - #43

Merged
wdeconinck merged 4 commits into
ecmwf:developfrom
pardallio:feature/arch-dir
Jul 7, 2026
Merged

adds --arch-dir argument to point to specific architecture directories#43
wdeconinck merged 4 commits into
ecmwf:developfrom
pardallio:feature/arch-dir

Conversation

@pardallio

Copy link
Copy Markdown
Contributor

Description

In response to Issue #36

ecbundle build looks for archs either in the arch folder or in the running directory, so the simplest way to do it is just to pass --arch relative/path/from/working/directory/to/extra-archs/(...) but it seems highly non-ideal.

This PR allows an --arch-dir argument to be passed to ecbundle create, which populates the source directory with the folder given in arch-dir.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.68%. Comparing base (ce56b30) to head (2c6a5a4).

Files with missing lines Patch % Lines
ecbundle/create.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    40.66%   40.68%   +0.01%     
===========================================
  Files           49       49              
  Lines        10156    10161       +5     
===========================================
+ Hits          4130     4134       +4     
- Misses        6026     6027       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdeconinck wdeconinck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pardallio for this improvement!

@wdeconinck
wdeconinck merged commit 4ed6022 into ecmwf:develop Jul 7, 2026
4 checks passed
wdeconinck added a commit that referenced this pull request Jul 28, 2026
* release/2.5.0:
  Version 2.5.0
  ci: migrate ecmwf-actions references to ecmwf (#42)
  Updates to ecbundle-merge (#47)
  Add "ecbundle merge" functionality (#46)
  Add --arch-dir argument to point to specific architecture directories (#43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants