Don't use find_package to lookup newly created virtual env - #104
Merged
Conversation
Contributor
Author
wdeconinck
reviewed
Jul 30, 2026
wdeconinck
left a comment
wdeconinck
left a comment
Member
There was a problem hiding this comment.
It definitely looks more sane not to try to change and restore a possible cache variable indeed.
reuterbal
suggested changes
Jul 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #104 +/- ##
========================================
Coverage 51.07% 51.07%
========================================
Files 58 58
Lines 4854 4854
Branches 453 453
========================================
Hits 2479 2479
Misses 2375 2375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
reuterbal
approved these changes
Jul 31, 2026
wdeconinck
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bundle builds, we may arrive at a situation where
Python3_EXECUTABLEis in fact a cache variable, which can lead to localfind_package(python3 ...)calls to be silently ignored. As such, this PR updates the fckit virtual env discovery to encode the path to the newly created python interpreter rather than relying on thefind_packagelookup.