Fix deduplication cleanup under multi-tenant with no default connection (#667)#670
Merged
Merged
Conversation
…on (#667) Console commands were dispatched via MessagingEntrypointService::sendWithHeaders(), which sets headers on the message but does not push them onto the propagated-header context. HeaderBasedMultiTenantConnectionFactory resolves the tenant only from that context, so a CLI --header tenantId:<tenant> was invisible to it and the cleanup command threw under a multi-tenant setup with no default connection. Dispatch console commands via sendWithHeadersPropagation() so CLI-supplied headers participate in propagation, consistent with the command/event buses. This enables tenant-aware console commands, e.g. running the deduplication cleanup once per tenant with --header tenantId:<tenant>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change proposed?
Fixes #667 —
ecotone:deduplication:remove-expired-messagesfails under a multi-tenantconnection setup that has no default connection.
With
MultiTenantConfigurationand no default connection, running the cleanup command throws:Description of Changes
Run once per tenant (e.g. from the scheduler) to clean each tenant's
ecotone_deduplicationtable.Pull Request Contribution Terms