Fix/ratelimit stale eviction#3
Open
ademboukabes wants to merge 1 commit into
Open
Conversation
…t unbounded memory growth
a2489bc to
1617662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ratelimitpackage maintains abyKeymap that creates a new*rate.Limiterfor every distinct source name. Because these limiters are never removed, the map grows indefinitely. This presents a vulnerability where an attacker could exhaust process memory over time simply by sending requests with many randomized source names.Solution
This PR updates the token bucket implementation to track its last access time and introduces an
EvictStalemethod.*rate.Limiterin an internalbucketstruct that recordslastSeen.EvictStale(olderThan time.Time) intto allow the caller to periodically prune buckets that haven't been accessed recently.time.Sleep.Verification
EvictStaleverifying removal of stale buckets and retention of active ones.go vetandgo test -race ./...pass successfully.