Repository navigation
Conversation
Good question. Prior to this PR we know that the |
daveedvdv-nvidia
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
I added some comments. Many are just formatting nits.
The significant one is that I think these changes make the #pragma "recognized", and so we should no longer issue a diagnostic for it.
Previously these pragmas were relocated to the top of the function, which cause a compilation error in the emitted C
|
@daveedvdv-nvidia and @wchilders-nvidia I believe have addressed all of your comments. |
|
I have re-run the CI since I think this was affected by the GitHub actions outage yesterday. Everything is back to green. |
In #165 we found that GCC loop pragmas such as
#pragma GCC unroll 4were relocated to the top of the function, causing a compilation error from the emitted C. This PR adds support for GCC's three loop pragmas:unroll,ivdep, andnovector, and ensures that they stay immediately before the loop, rather than being relocated. Previous tests with unrecognized or unhandled loop pragmas have been updated to reflect this new support.Closes: #174