Repository navigation
default integer value limits to 128 bits with __int128 extensions, fix for [GH #38] - #265
Open
mohitmishra786 wants to merge 1 commit into
Open
mohitmishra786 wants to merge 1 commit into
mohitmishra786 wants to merge 1 commit into
Conversation
… are allowed. [GH edgcpp#38]
Contributor
Author
|
@wchilders-nvidia @nv-cmeerw @daveedvdv could you please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
With a 128-bit host integer representation, MAX_INTEGER_VALUE, MIN_INTEGER_VALUE and MAX_UNSIGNED_INTEGER_VALUE stayed at their 64-bit values, so the overflow checks in const_ints.c rejected valid __int128 constant arithmetic (
(__int128)1 << 100times 4 gave "expression must have a constant value"). The macOS CMake configurations use this representation by default.Testing (Docker, linux-gcc-debug):