Only stop prompt on explicit stop command#67
Merged
ericdallo merged 1 commit intoeditor-code-assistant:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the Neovim client notifies the server to stop generation so that chat/promptStop is only sent on the explicit stop command, avoiding unintended stops triggered by internal UI finalization events.
Changes:
- Removed the
chat/promptStopsend fromSidebar:_finalize_streaming_response()to prevent stops on non-stop events (e.g.,toolCallPrepare). - Added
chat/promptStopsend to the:EcaStopResponseuser command so stopping is explicit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lua/eca/sidebar.lua | Removes server stop notification from shared streaming finalization logic. |
| lua/eca/commands.lua | Sends chat/promptStop as part of :EcaStopResponse instead of during generic finalize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
399
to
406
| -- Force stop any ongoing streaming response | ||
| local chat_id = chat.mediator:id() | ||
| if chat_id then | ||
| chat.mediator:send("chat/promptStop", { chatId = chat_id }, nil) | ||
| end | ||
|
|
||
| if eca.sidebar then | ||
| eca.sidebar:_finalize_streaming_response() |
| vim.api.nvim_create_user_command("EcaStopResponse", function() | ||
| local eca = require("eca") | ||
| local chat = eca.get() | ||
| local Utils = require("eca.utils") |
Comment on lines
399
to
+403
| -- Force stop any ongoing streaming response | ||
| local chat_id = chat.mediator:id() | ||
| if chat_id then | ||
| chat.mediator:send("chat/promptStop", { chatId = chat_id }, nil) | ||
| end |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes “Prompt stopped” on toolCallPrepare and other unwanted events introduced in #63. This moves the “chat/promptStop” instruction inside the “EcaStopResponse” instead of the shared
_finalize_streaming_responsefunction.