Fix/same bounds multi flow - #144
Merged
Merged
Conversation
Ensure `bounds()` and depth-zero `transition()` use the same selected frame as the interpolator’s direct properties. This prevents settled reveal transitions from reactivating when a later screen reuses the same boundary ID.
✅ Deploy Preview for rnst-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In multi-screen navigation flows, a completed bounds reveal transition could reactivate when pushing another route that reused the same boundary ID.
The outgoing interpolator was evaluated with a filtered view of the transition, but its
bounds()and depth-zerotransition()helpers still read the latest navigation frame. This mismatch allowed a settled reveal target to pair with an element on the newly pushed screen, causing it to animate out unexpectedly.This change ensures the interpolator and its helpers use the same transition frame, preserving completed reveal states while allowing subsequent transitions to handle matching boundary IDs independently.