Fix/group bounds - #145
Merged
Merged
Conversation
✅ Deploy Preview for rnst-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This patch addresses several transition issues discovered while using bounds and gesture-driven dismissal in more demanding application flows.
Transition.Boundary.Hostcould become unreliable inside large, dynamic, or virtualized lists. Escaped source boundaries depended on external host and scroll bookkeeping, which could become stale after scrolling or recycling content. This caused transitioned elements to render at an outdated position or temporarily disappear. Boundary hosts now use measurements local to their boundary, making escaped source positioning immediate and independent of the surrounding scroll implementation.Grouped boundaries could also retain stale measurements after their active ID changed. Changing the active member of a group is now treated as an explicit refresh signal, ensuring dismissal targets the currently active source.
Dismissal additionally had separate gesture and programmatic completion paths. This could allow navigation removal and transition animation to become unsynchronized, producing stutters, premature removal, or stale lifecycle state. Both paths now request the same soft dismissal, while a single lifecycle listener completes navigation once the screen is closing and its animation progress reaches zero.
Together, these changes make grouped retargeting predictable, improve escaped-boundary behavior in large lists, and give gesture and programmatic dismissal one consistent lifecycle.