Repository navigation
Drop eigen_shell's unused cupertino_icons dependency - #144
Merged
Merged
Conversation
Nothing in the shell draws a Cupertino icon -- the dependency is an app template leftover. Dependabot proposed its 2.0.0 major (#143); removing it is the change that actually fits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmaAaAfMjsU7ETTRmS93gV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's first working Dart run (after #142) opened #143,
cupertino_icons1.0.9 → 2.0.0 inshell/pubspec.yaml. Nothing inshell/,flutter/orfirebase/usesCupertinoIconsor any Cupertino widget; the dependency is an app-template leftover from 057c93a. Removing it fits better than taking a major of a package we don't use.What
shell/pubspec.yaml: removecupertino_icons.pubspec.lockis unchanged (it stays as a transitive entry).shell/CHANGELOG.md: a Cider "Removed" entry, so the next Dart release ships it.Verification
./tool/check.sh shellpasses: analyze, tests, code-generation drift andpub publish --dry-run(0 warnings).After merge
Comment
@dependabot recreateon #143; with the dependency gone Dependabot closes it.🤖 Generated with Claude Code
https://claude.ai/code/session_01AmaAaAfMjsU7ETTRmS93gV