Skip to content

fix: keep a refused Session showing its error after a reload - #2088

Merged
Douglasymlai merged 9 commits into
mainfrom
fix/refused-run-after-reload
Oct 26, 2026
Merged

Douglasymlai merged 9 commits into
mainfrom
fix/refused-run-after-reload

Conversation

@Douglasymlai

@Douglasymlai Douglasymlai commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed repair; no linked issue required for this PR.

Description

Problem

A model-capability refusal left a pending task without an attempt. Reloading lost its error and could leave queued work waiting.

Change

Persist a failed task event and refusal reason for permanent initial admission refusals. Protect admitted and foreign tasks, reject the matching queued request atomically, and keep a request without execution evidence out of the planning display. Transient Session-busy conflicts remain retryable rather than becoming failed Runs. Updated against current main.

Testing Evidence (REQUIRED)

  • 74 backend/controller tests passed, 1 existing skip, including permanent refusal, retryable 409, replay reason, subsequent admission, and ownership protection.
  • 92 frontend tests passed for Project state and pending planning; type checking, focused ESLint/Prettier, repository Ruff, and git diff --check passed.
  • Existing primitives and semantic styling retained; no new UI components, tokens, or exceptions.
  • No packaged-app refusal/reload scenario was run. Remote CI is triggered by the updated head.
  • Follow-up fix: refusing a queued follow-up now closes its queue row as cancelled (the previous value failed a database check and left the task pending). New regression test queues a follow-up before the refusal; 11 related backend tests pass.

Automated checks only; manual app testing is pending.

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai Douglasymlai self-assigned this Oct 22, 2026
@Douglasymlai
Douglasymlai marked this pull request as ready for review October 22, 2026 21:48
@Douglasymlai
Douglasymlai merged commit ca19a0f into main Oct 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant