Skip to content

fix: format all dates in the app language - #2094

Merged
Douglasymlai merged 5 commits into
mainfrom
fix/dates-follow-app-language
Oct 25, 2026
Merged

Douglasymlai merged 5 commits into
mainfrom
fix/dates-follow-app-language

Conversation

@Douglasymlai

@Douglasymlai Douglasymlai commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed repair; no linked issue required for this PR.

Description

Problem

Dates could use the OS language instead of the selected app language.

Change

Use the shared app-language formatter for Home/Space dates, Automation previews, version history, commit timelines, Dispatch, and Remote Control. Merge current main while preserving the shared DsIcon imports. Remote sync dates explicitly depend on the selected language.

Testing Evidence (REQUIRED)

  • 65 focused frontend tests passed; type checking, focused ESLint/Prettier, design-token checks, locale parity/source checks, and git diff --check passed.
  • Production WorkspaceCommitTimeline rendered in a localhost fixture: changing English to French immediately changed the displayed date.
  • Existing primitives and semantic styling retained; no token or geometry changes and no new exceptions.
  • Full packaged-app and every date surface were not exercised. GitHub CI is running on c8ffae8.

The HTML design viewer still presents the older proposal; the authoritative Markdown guideline was followed.

Automated checks only; manual app testing is pending.

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai Douglasymlai self-assigned this Oct 22, 2026
@Douglasymlai
Douglasymlai marked this pull request as ready for review October 22, 2026 21:48
@Douglasymlai
Douglasymlai merged commit 2c7b1d9 into main Oct 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant