Repository navigation
feat: show approvals and questions above the message box - #2095
Merged
Merged
Conversation
Douglasymlai
force-pushed
the
feat/approvals-above-composer
branch
from
October 22, 2026 22:49
ecc66d8 to
0d56b5c
Compare
Douglasymlai
force-pushed
the
feat/approvals-above-composer
branch
from
October 22, 2026 23:59
0d56b5c to
b5bfe10
Compare
Douglasymlai
marked this pull request as ready for review
October 23, 2026 00:00
Douglasymlai
force-pushed
the
feat/session-header-menu
branch
from
October 23, 2026 00:19
eb72c6c to
ccc5e95
Compare
Douglasymlai
force-pushed
the
feat/approvals-above-composer
branch
from
October 23, 2026 00:19
0511644 to
4b40279
Compare
Douglasymlai
force-pushed
the
feat/approvals-above-composer
branch
from
October 23, 2026 00:21
4b40279 to
eff55a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1958 so it can be reviewed on its own.
Problem
When an agent needs permission or asks a question, the request replaces the message box. The request is hard to tell apart from the normal composer, and technical details compete with the actual question. When one request is answered and another arrives right away, the next one can appear under the cursor, so a quick second click could answer a request you haven't read yet.
Cause
Approvals and questions were rendered as variants of the composer itself, in the same frame as the message input, with the full technical header.
Fix
How decisions are made does not change: the same requests, options and handlers are used, and a request leaves the screen at the same point as before.
New copy: "Review next request" (all 11 locales).
Testing
npx vitest runonHumanDecisionCard.test.tsx(new),BottomBox.test.tsx,ControlInput.test.tsxandChatBox.spaceModelSelection.test.tsx: 121 passed.test/unit/components/ChatBoxandtest/unit/components/Workspacesuites: 863 passed.npm run type-check,npm run check:i18n,npm run check:design-tokens, ESLint and Prettier on changed files,git diff --check: pass.HumanDecisionCard.test.tsxcase builds an approval through the event-based view with a target file and a command argument, and checks that the target and the Review details section with the command are shown. It fails if the card hides them again.HumanDecisionCard,BottomBox,ControlInput,ChatBoxandChatBox.spaceModelSelectionsuites: 241 passed.textarea.test.tsxchecks the borderless answer field style and that the default style is unchanged, and newControlInput.test.tsxcases check that a question uses it and other feedback keeps the framed field. The new assertions fail without the change.test/unit/components/ui,HumanDecisionCard,BottomBox,ControlInput,ChatBoxandChatBox.spaceModelSelectionsuites: 257 passed.npm run check:design-systempasses.enhancedoroutlinedstyles.