Repository navigation
feat: align the default chat view's work log with Narrative - #2102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #2101 on
main. #2101 was merged into its stacked base branch after #2100 had already been merged, so its change never reachedmain. This PR carries the identical change on top of currentmain(split out of #1958).Problem
In the default chat view, the work log under each task described tool calls differently from the Narrative view. Rows read like
Browser Toolkit · Browser visit page · 2 eventsor showed the raw argument text, they had no icon, and the agent and work-log chevrons were always visible. The final answer's text also sat flush against the edge while the rest of the conversation was inset.Cause
The Narrative view's row titles, subjects and icons were only used by the event-based timeline. The default chat view still built its own
Toolkit · Methodtitles.Fix
Known limit: the default chat view only knows whether a call is running or done. A call that failed, or was cut short when a task was stopped, still reads as done here. Narrative shows those states.
Testing
In the app (macOS, default chat view), with Tasks that used the terminal, web search, a web fetch, file writes and Stop:
Automated:
TaskWorkLogAccordionand the new live-language test: all pass. New tests cover:npm run type-check,npm run check:i18n,npm run check:design-tokens, ESLint and Prettier: pass.mainfor this PR: Vitest on ChatBox, Session,TaskWorkLogAccordionand the live-language test (1001 passed), plus type-check,check:i18n,check:design-tokens, ESLint and Prettier.Testing Evidence