Skip to content

fix: keep browser tools when resuming a task - #2109

Open
Douglasymlai wants to merge 3 commits into
mainfrom
fix/resume-browser-tools
Open

Douglasymlai wants to merge 3 commits into
mainfrom
fix/resume-browser-tools

Conversation

@Douglasymlai

@Douglasymlai Douglasymlai commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed repair; no linked issue required for this PR.

Description

Problem

Resume sent no new message to the browser-intent check, so a task could restart without the browser tools it previously had.

Change

Use the original request plus recorded browser tool calls/model tool manifests to decide whether to reconnect. Preserve evidence across attempts and ignore hints from another Session. Run summaries expose browser evidence; a missing Eigent-owned target adds an explicit notice to resumed agents' prompts. The existing browser ownership and authorization gate is unchanged.

Testing Evidence (REQUIRED)

  • 256 distinct frontend tests and 92 backend tests passed, including new-task/Resume transport, original intent, recorded tools without keywords, foreign-Session evidence, unavailable targets, SQLite evidence and Run API controls.
  • Type checking, focused ESLint/Prettier, repository Ruff and git diff --check passed.
  • Real Electron fixture: production WebViewManager, intent classifier and resolver returned an exact owned target for original intent and saved browser use; destroying the view returned no targets.
  • No complete paid model interruption/Resume task was run. No UI geometry, primitives, tokens or design exceptions changed.
  • Follow-up fix: the Session run list no longer computes earlier browser use (only the single task being resumed does), and Resume continues if that lookup fails. New test proves Resume still connects the browser from the original request when the lookup errors; 23 backend + 5 frontend tests pass; type-check passes.

Automated checks only; manual app testing is pending.

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai
Douglasymlai marked this pull request as ready for review October 25, 2026 17:33
@Douglasymlai Douglasymlai self-assigned this Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant