Repository navigation
fix: remove each task's copy of the terminal environment when it is done - #2111
Open
Douglasymlai wants to merge 3 commits into
Open
Douglasymlai wants to merge 3 commits into
Douglasymlai wants to merge 3 commits into
Conversation
Douglasymlai
marked this pull request as ready for review
October 25, 2026 17:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
N/A — maintainer-directed repair; no linked issue required for this PR.
Description
Completed tasks kept separate terminal environments indefinitely. Release Run-owned environment copies after terminal sessions/checkpoints stop, retain interrupted environments for Resume, and rebuild a retained toolkit’s missing environment when needed. Cleanup failure is logged without rewriting the Run outcome.
Session deletion requests a guarded local runtime purge. Background retention runs off the event loop with the plan’s 24-hour TTL (including interrupted copies), 10 GiB soft budget and pressure below 10% free disk. Active runs and symlink/outside-owner paths are protected.
Testing Evidence (REQUIRED)
48 backend tests and 25 frontend tests passed: real filesystem removal, lingering-session refusal, Run-scoped ownership, single-flight cleanup, the actual successful coordinator hook, endpoint active guard, traversal/symlink rejection and retention/pressure behavior. Type-check, focused ESLint/Prettier, Ruff and git diff --check passed. Tests used isolated temporary application storage; no user runtime was deleted. Full paid task/relaunch QA was not run.
Automated checks only; manual app testing is pending.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement