Fix current swap-core unit tests#1007
Open
dennywu2966 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #724
Problem:
swap-coreunit tests still failed when the test wallet was used throughdyn BitcoinWallet; helper methods in the test wallet impl still panicked instead of calling the real wallet code.parse_monero_overflowsexpected an old custom overflow error, whileAmount::parse_moneronow returns the current generic error.Changes:
Wallet<Connection, StaticFeeRate>test-wallet trait methods used by the unit tests to the existing wallet implementations.Verification:
cargo test -p swap-core --lib-> 68 passed.cargo test --no-fail-fast -p swap-core -p swap-feed -p swap-orchestrator-> passed for all targets in that group.rustfmt --edition 2024 --check bitcoin-wallet/src/wallet.rs swap-core/src/monero/primitives.rs-> passed.git diff --check-> passed.Local verification note: Cargo could not fetch the Arti
arti-corporasubmodule from GitLab in this environment, so the cargo test runs used a temporary local path override for the cached Arti checkout. That override is not part of this PR. I also triedcargo test -p swap-asb; it did not reach repo tests because the local Monero submodules could not be fetched from GitHub after retries.AI assistance: OpenAI Codex helped prepare and test this patch.