ci: also build SarConfigure and SarCtl in the usermode job - #146
Merged
Merged
Conversation
Both are plain MSVC projects with no WiX dependency, so they cost nothing extra on the runner and a compile break in them no longer goes unnoticed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Ae1KbSGxTuh8F6i85MGxp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #143. The usermode job only built SarAsio, so a compile break in SarConfigure or SarCtl would go unnoticed. Both are plain MSVC projects with no WiX dependency, so this is a one-line change to the msbuild target list.
The target list has to be quoted: PowerShell treats an unquoted
;as a statement separator, which runsSarConfigureandSarCtlas commands and leaves msbuild with only/t:SarAsioand no platform.Verified on a fork run of this exact change on top of master + #145: driver (x64), usermode (x64) and usermode (x86) all pass, and both new projects build for x64 and x86 with no warnings.
🤖 Generated with Claude Code
https://claude.ai/code/session_015Ae1KbSGxTuh8F6i85MGxp