fix: constrain NVIDIA device plugin to GPU nodes - #8866
Open
atharvaHJoshi wants to merge 1 commit into
Open
atharvaHJoshi wants to merge 1 commit into
atharvaHJoshi wants to merge 1 commit into
Conversation
Signed-off-by: Atharva Joshi <josh.atharva2005@gmail.com>
Contributor
|
Hello atharvaHJoshi 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8858
Related to #8859.
What this PR does
The NVIDIA device-plugin DaemonSet had no
nodeSelector/node affinity, so a DaemonSetreplica was scheduled on every node, including CPU-only nodes where it has no GPU
to manage — crash-looping and potentially taking down unrelated nodes via DiskPressure.
How this differs from #8859
#8859 adds a
nodeSelectoronnvidia.com/gpu.present: true. That label is not setby anything in the standard eksctl flow (eksctl installs the device plugin directly; it
does not use the GPU Operator / node-feature-discovery), so under that PR the DaemonSet
would never schedule at all and GPUs would not be exposed as resources.
This implementation instead:
(unmanaged
InstanceType+InstancesDistribution.InstanceTypes, managedInstanceType+InstanceTypes),node.kubernetes.io/instance-typelabel (always populated by kubelet), andeks.amazonaws.com/compute-type NotIn.This works reliably, including on mixed instance-type nodegroups where only the GPU
variants run the plugin.
Changes
SetNodeAffinityto theDevicePlugininterface; no-op for Neuron/EFA.NvidiaDevicePlugin.SetNodeAffinity.no-op for CPU-only clusters).
Validation
go build ./...golangci-lint run --timeout=30m ./pkg/...go test ./pkg/addons/...Pre-existing, unrelated failures in
pkg/infoandpkg/iam/oidcare environmental(kubectl/
cfsslmissing locally) and remain unchanged.