feat: shopper/admin attributes, bundle min/max, catalog rule validation, pricebook segmentation#89
Merged
Merged
Conversation
mzaintariq
approved these changes
May 6, 2026
|
🎉 This PR is included in version 33.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 13, 2026
field123
added a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
Summary
Brings the legacy SDK in line with recent additions to the upstream PIM (
pim.yaml) and shopper Catalog View (catalog_view.yaml) OpenAPI specs. All changes are additive — no breaking changes.From
pim.yaml(admin / PXM)shopper_attributes/admin_attributeson products — adds the two{ [key: string]: string }maps toPcmProductBase.attributes(the equivalent fields are already onHierarchyBaseandNodeBase, so this rounds out the trio).min/maxon bundle component options — addsminandmaxtoProductComponentOption(component-levelmin/maxalready exists onProductComponents).columns.include— adds an optional third argument toExportProducts(filter, useTemplateSlugs, columns)and threads{ data: { type: 'product', attributes: { columns } } }through as the request body. Supports individual keys (admin_attributes.cost_of_goods) and wildcards (admin_attributes.*).From
catalog_view.yaml(shopper / catalog)ValidateonRules— newPOST /catalogs/rules/validatemethod on theCatalogsRulesEndpoint. AddsCatalogRuleValidatorRequest(withmatch_typeoffilter|similarity|conflict|resolve_for_shopper),RuleMeta(similarity_score,active,resolved_for_shopper,release_id),ValidatedRule, andValidateRulesResponse.pricebook_idsonRuleFilter— populates the previously-stubRuleFilterinterface witheqandinoperators againstid,catalog_id,account_ids,customer_ids,channels,tagsand the newpricebook_ids. Also addspricebook_ids?: string[]onRuleBase.attributes.available_prices,alternative_pricesandavailable_pricebook_idsonProductResponse.attributes. Component product metadata also gainsalternative_prices. NewAvailablePrice,AlternativePriceandPriceTiertypes.ReleaseIndexingCompleteData— new type for the indexing-complete payload ({ data: { status: 'succeeded' | 'failed' } }).Out of scope
EP-Pricebook-IDs-Of-Available-Prices-To-Showrequest header isn't threaded through the relevantCatalog/Catalogs.Productsmethods. The request factory already supportsadditionalHeadersso this could be done as a follow-up; threading it through every method is a larger API surface change worth its own PR.Test plan
yarn lintcleanyarn rollupbuilds clean (existingCodeFileHrefre-export warning is pre-existing onmain)yarn test— pre-existing environment issue onmain(chaimodule not linked under current Node version) blocks the suite; not introduced here