Custom eslint rules - #35
Conversation
| */ | ||
|
|
||
| const tasks = { | ||
| let tasks = { |
There was a problem hiding this comment.
You probably don't need to change this.
|
Thanks for the PR. The general approach is good. If CWD/.eslintrc and CWD/test/.eslintrc exist, then use those instead of the ones in the archetype. Eventually these are all the eslint check scripts https://github.com/electrode-io/electrode-archetype-react-app/blob/master/arch-gulpfile.js#L189-L192 One of the things I was considering is to allow apps to override archetype config. https://github.com/electrode-io/electrode-archetype-react-app/blob/master/config/archetype.js |
|
In most cases, people are using only one linter config file (I think). But sure, if you want I could check for |
|
|
||
| // Check if any .eslintrc file exists on the | ||
| // project root path. | ||
| const customLinterPath = Path.join(process.cwd(), ".eslintrc"); |
There was a problem hiding this comment.
Since eslint --init can generate files like .eslintrc.json, can this accept:
- no extension
.js.json?
|
@kooparse +1 on separate configuration files, esp. since the archetype has the separation anyway. However, ESLint doesn't support globbing/custom directories for
I've tested such placement (one |
It is perhaps preferable to wait the plugin model (#30).