Skip to content

chore: replace eslint with oxlint - #617

Merged
MarshallOfSound merged 2 commits into
mainfrom
oxlint
Sep 16, 2026
Merged

MarshallOfSound merged 2 commits into
mainfrom
oxlint

Conversation

@claude

@claude claude Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Before: yarn lint ran ESLint 8 with @typescript-eslint/* and eslint-plugin-ava via a legacy .eslintrc.json.

After: yarn lint runs oxlint src spec from .oxlintrc.json with the correctness category as errors and the typescript plugin; ESLint and its plugins are gone.

  • Removed eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, eslint-plugin-ava; added oxlint@1.81.0.
  • oxlint is pinned exactly to 1.81.0 rather than ^1.81.0: this repo is still Yarn 1 with no npm minimum-age gate, and the caret resolved to the 5-day-old 1.82.0, which Socket blocks and which the other (age-gated) Electron repos are not on yet.
  • Added .oxlintrc.json (mirrors chore: replace eslint with oxlint github-app-auth-action#174, minus the import/vitest plugins); deleted .eslintrc.json.
  • Carried over no-var, eqeqeq, prefer-const, no-unused-vars, typescript/no-explicit-any, typescript/no-inferrable-types, typescript/no-non-null-assertion (warn); typescript/no-require-imports stays off to match the old no-var-requires: off.
  • Dropped rules with no oxlint equivalent: eslint-plugin-ava (oxlint has no ava plugin) and the stylistic indent/semi/quotes rules (oxlint does not ship formatting rules).
  • Scripts: lintoxlint src spec, new lint:fix; removed the now-obsolete // eslint-disable-next-line prefer-const in src/index.ts. Not type-aware, since the old config was not either.

Verified on Linux: yarn lint clean, yarn build (tsc) clean, and the 3 pure ava specs (assert-supported-arch, convert-version, sanitize-authors) pass; installer-spec/sign-spec need Wine + Mono (or Windows) and were not run here, so CI covers them.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
@socket-security

socket-security Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxlint@​1.81.0991009196100

View full report

@socket-security

socket-security Bot commented Sep 12, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
@claude
claude Bot marked this pull request as ready for review September 12, 2026 23:56
@claude
claude Bot requested a review from a team as a code owner September 12, 2026 23:56
@MarshallOfSound
MarshallOfSound merged commit a5b6033 into main Sep 16, 2026
10 checks passed
@MarshallOfSound
MarshallOfSound deleted the oxlint branch September 16, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants