chore: replace eslint with oxlint - #617
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
MarshallOfSound
approved these changes
Sep 13, 2026
MarshallOfSound
enabled auto-merge (squash)
September 13, 2026 00:26
dsanders11
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Before:
yarn lintran ESLint 8 with@typescript-eslint/*andeslint-plugin-avavia a legacy.eslintrc.json.After:
yarn lintrunsoxlint src specfrom.oxlintrc.jsonwith thecorrectnesscategory as errors and thetypescriptplugin; ESLint and its plugins are gone.eslint,@typescript-eslint/eslint-plugin,@typescript-eslint/parser,eslint-plugin-ava; addedoxlint@1.81.0.oxlintis pinned exactly to 1.81.0 rather than^1.81.0: this repo is still Yarn 1 with no npm minimum-age gate, and the caret resolved to the 5-day-old 1.82.0, which Socket blocks and which the other (age-gated) Electron repos are not on yet..oxlintrc.json(mirrors chore: replace eslint with oxlint github-app-auth-action#174, minus theimport/vitestplugins); deleted.eslintrc.json.no-var,eqeqeq,prefer-const,no-unused-vars,typescript/no-explicit-any,typescript/no-inferrable-types,typescript/no-non-null-assertion(warn);typescript/no-require-importsstays off to match the oldno-var-requires: off.eslint-plugin-ava(oxlint has no ava plugin) and the stylisticindent/semi/quotesrules (oxlint does not ship formatting rules).lint→oxlint src spec, newlint:fix; removed the now-obsolete// eslint-disable-next-line prefer-constinsrc/index.ts. Not type-aware, since the old config was not either.Verified on Linux:
yarn lintclean,yarn build(tsc) clean, and the 3 pure ava specs (assert-supported-arch, convert-version, sanitize-authors) pass;installer-spec/sign-specneed Wine + Mono (or Windows) and were not run here, so CI covers them.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs