Port ProcessTreeView to GTK4#525
Open
stsdc wants to merge 55 commits into
Open
Conversation
…dering if integer values do not change on the view
danirabbit
reviewed
Mar 5, 2026
danirabbit
reviewed
Mar 5, 2026
danirabbit
reviewed
Mar 5, 2026
danirabbit
reviewed
Mar 5, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Made a few comments about code style etc
ryonakano
reviewed
May 18, 2026
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Just take a glance at the changes, but leaving some comments that I noticed or concerned.
…rty in the same code step
Member
Author
|
@ryonakano thank you for the review! It did help a lot to cleanup this PR. I think I have addressed all of them. Let me know if you have any more concerns 👍 |
ryonakano
reviewed
May 24, 2026
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Thanks for the fix, I'm leaving some additional comments.
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Member
Author
|
Thank you, @ryonakano, I have addressed your findings. |
stsdc
force-pushed
the
stsdc/gtk4-treeview
branch
from
f1b7cd1 to
cc25a41
Compare
ryonakano
reviewed
May 25, 2026
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Seems like working as expected. Another small nitpickings otherwise LGTM.
Member
Author
|
Hi @ryonakano all done 👍 |
…e ProcessTreeView constructor
stsdc
force-pushed
the
stsdc/gtk4-treeview
branch
from
2a4bd1c to
1716039
Compare
ryonakano
approved these changes
May 26, 2026
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing my comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to future proof the process list and lay some ground for a tree view reintroduction.