Conversation
ryonakano
marked this pull request as draft
September 14, 2026 12:01
ryonakano
marked this pull request as ready for review
September 14, 2026 16:18
ryonakano
marked this pull request as draft
September 14, 2026 16:27
ryonakano
force-pushed
the
ryonakano/port-to-libical-4
branch
from
September 15, 2026 12:40
16ddafc to
7e18722
Compare
ryonakano
force-pushed
the
ryonakano/port-to-libical-4
branch
from
September 15, 2026 12:44
7e18722 to
8395bae
Compare
ryonakano
marked this pull request as ready for review
September 15, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: elementary/contacts#49 (but newer versions)
Changes Summary
ICal.Duration.extend()instead ofICal.Time.add()ICal.Duration.from_time()instead ofIcal.Time.substract()ICal.Duration.as_seconds()instead ofICal.Duration.as_int()