Skip to content

Internal: Update Elementor install in daily test matrix [TMZ-1028]#628

Open
hein-obox wants to merge 5 commits intomainfrom
internal/TMZ-1028-fix
Open

Internal: Update Elementor install in daily test matrix [TMZ-1028]#628
hein-obox wants to merge 5 commits intomainfrom
internal/TMZ-1028-fix

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 8, 2026

✨ PR Description

1. Problem & Context

Removed excessive debug logging from Elementor installation logic in CI test matrix (TMZ-1028). The previous implementation had verbose emoji-laden debug output and complex branching that made logs noisy. Simplified to a cleaner validation check with fallback to WordPress.org versions when local artifacts aren't available.

2. What Changed (Where)

  • .github/scripts/build-wp-env.js: Refactored Elementor plugin installation logic, removed ~100 lines of debug logging, simplified version resolution

3. How It Works

Validates local Elementor build by checking for three essential files (elementor.php, includes/, assets/). If valid, uses ./tmp/elementor; otherwise extracts semantic version from ELEMENTOR_VERSION env var and downloads from WordPress.org. Removed the previous fallback-on-error logic that masked build failures. Logs now show actual source used (elementorSource) instead of requested version.

4. Risks

None. This is cleanup of debug code. The core logic (local build validation → WordPress.org fallback) remains functionally equivalent, just cleaner. The removal of the error-masking fallback actually improves CI signal by failing fast on invalid builds rather than silently falling back to latest-stable.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI wp-env generation to reduce Elementor version drift between build and test jobs by preferring a locally downloaded Elementor artifact (when present/valid), with simpler fallback behavior and less noisy logging.

Changes:

  • Prefer ./tmp/elementor as the Elementor plugin source when it looks like a valid artifact.
  • Fall back to WordPress.org downloads for semantic versions, otherwise default to latest-stable.
  • Remove extensive Elementor artifact debug logging from the script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/scripts/build-wp-env.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/scripts/build-wp-env.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/scripts/build-wp-env.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/scripts/build-wp-env.js Outdated
Comment thread .github/scripts/build-wp-env.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/scripts/build-wp-env.js
Comment thread .github/scripts/build-wp-env.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants