OSAC-4049/4018: GitHub Actions YAML extraction, ci-select, metadata.json contract doc - #5
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eliorerz
force-pushed
the
feat/gh-actions-yaml-extract
branch
2 times, most recently
from
August 25, 2026 14:51
4b59ebb to
14adeac
Compare
… CI test selection Add a new subcommand that uses the knowledge graph to determine which tests need to run based on changed files. Supports cross-repository test selection when changes in one repo affect dependencies in another repo.
Add a JSON Schema for the metadata.json file that accompanies published graph bundles. This schema serves as the single source of truth for both the CI job that generates the bundle and the fetch script that consumes it, preventing drift between writer and reader implementations. The schema defines fields for version tracking (source_sha, graphify_version), staleness detection (generated_at), and bundle file paths (graph.json, GRAPH_REPORT.md, manifest.json).
- Add looks_like_workflow_shape() content check to prevent non-workflow files at workflow paths from being misclassified - Fix UnicodeDecodeError handling in cache corruption detection - Harden install_references write probe for root/elevated contexts - Gate test platform capabilities (mkfifo, AF_UNIX, symlinks) on actual availability - Fix whitespace and comment clarity throughout These are real bug fixes caught in code review, not just style improvements.
… bugs - Move workflow-shape gate to top of _get_extractor() before manifest checks - Fix comment-before-value parsing in block sequence items (prevents comments from being read as dependency names) - Consolidate .yaml/.yml dispatch logic
eliorerz
force-pushed
the
feat/gh-actions-yaml-extract
branch
from
August 25, 2026 14:56
14adeac to
e398e7b
Compare
1. Check diff command exit status and report failures (was silently using empty output) 2. Kill timed-out diff subprocess to prevent orphaned processes 3. Fix repo-relative path detection - paths like 'internal/servers/file.go' were incorrectly split as repo='internal', file='servers/file.go'. Now only treats single-component prefixes (no slashes) as repo names. 4. Add inline security note that --diff-cmd executes through shell Addresses findings from PR Graphify-Labs#3087 review: - 'ci-select ignores failed diff command exit status' - 'Timed-out diff command can leave child processes running' - 'Repo-relative source files with directories are treated as cross-repo' - 'User-controlled --diff-cmd is executed through the shell' (documented, by design)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores/proposes the work that was previously sitting directly on
v8(not on its own branch), beforev8got reset to matchGraphify-Labs/graphify:v8exactly. Nothing was lost -- this branch already had the identical content -- but it now needs its own PR sincev8is a clean upstream mirror going forward.Commits
Add graphify ci-select subcommand for graph-informed CI test selection-- the token-saving CI test-selection feature referenced bydocs/ci/graph-informed-ci-setup.md. Not yet in any published graphifyy release (verified:graphifyy==0.9.41on PyPI has noci_selectmodule), so this is what actually ships it.OSAC-4018: Document metadata.json schema as a canonical contractOSAC-4049: Extract GitHub Actions workflow job/needs/uses under --code-only+ 3 follow-up fix commits (CodeRabbit review findings, git executable resolution via shutil.which(), extractor-precedence/comment-in-sequence bugs)Test plan
graphify ci-selectbehaves as documented indocs/ci/graph-informed-ci-setup.md