Skip to content

avoid compile-time dependency on modules named in derive #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Aug 9, 2026
+5 −3
Merged

avoid compile-time dependency on modules named in derive #4779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/ecto/schema.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,10 +2390,12 @@ defmodule Ecto.Schema do
on_writable_violation_default = Module.get_attribute(module, :on_writable_violation, :nothing)

struct_fields = Module.get_attribute(module, :ecto_struct_fields) |> Enum.reverse()
derive = Module.get_attribute(module, :derive)

if redacted_fields != [] and not List.keymember?(derive, Inspect, 0) and
derive_inspect?(module) do
# Reading @derive makes every module named in its options a compile-time
# dependency of the schema. Keep the read last so it is skipped unless a
# redacted field actually requires deriving Inspect.
if redacted_fields != [] and derive_inspect?(module) and
not List.keymember?(Module.get_attribute(module, :derive), Inspect, 0) do
Module.put_attribute(module, :derive, {Inspect, except: redacted_fields})
end

Expand Down
Loading