fix: Define Axon.ModelState.t() - #673
Closed
georgeguimaraes wants to merge 2 commits into
Closed
georgeguimaraes wants to merge 2 commits into
georgeguimaraes wants to merge 2 commits into
Conversation
georgeguimaraes
force-pushed
the
model-state-type
branch
from
September 15, 2026 18:41
09ca277 to
079b39a
Compare
polvalente
reviewed
Sep 15, 2026
polvalente
left a comment
polvalente
left a comment
Member
There was a problem hiding this comment.
Let’s not add this since we don’t validate with dialyzer. Specs like these are prone to users submitting PRs fixing the spec itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Axon.ModelStatehas no@type t, so any downstream spec that saysAxon.ModelState.t()gets an ex_doc warning about an undefined type. This adds it with the four struct fields as maps.