feat: add resolveJsonModule to @ember/{library,app}-tsconfig - #23
Merged
Merged
Conversation
Node 24 strips TypeScript types natively and supports JSON module imports
via `with { type: 'json' }`. TypeScript needs resolveJsonModule to
type-check those imports. Common use cases include build scripts and
root-level config files that need to read package.json.
NullVoxPopuli
approved these changes
Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on
resolveJsonModulein both base configs so JSON imports type-check out of the box.Why
Node 24 strips TypeScript types natively and supports JSON module imports via
with { type: 'json' }, which is now standard. TypeScript needsresolveJsonModuleto type-check those imports, otherwise consumers getTS2732: Cannot find module './package.json'.Common uses:
package.jsonin build scripts and root-level config filesScope
Flag only, no other behavior changes. Both
@ember/library-tsconfigand@ember/app-tsconfigare updated.Docs: https://www.typescriptlang.org/tsconfig/#resolveJsonModule