skip __proto__ keys when creating an object#21509
Open
ubeddulla wants to merge 1 commit into
Open
Conversation
Contributor
|
is this fixing a bug or anything you've encountered? wondering how this could come up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON.parsegives you__proto__as an own enumerable key, so it survives theObject.keysloop ininitializeand lands onobj[keyName] = value, which runs theObject.prototype.__proto__setter and re-parents the instance instead of setting a property. ThesetUnknownPropertybranch just above can't catch it either, since'__proto__' in objis always true. Concretely,SomeClass.create(JSON.parse('{"__proto__": {"isAdmin": true}}'))on a payload straight from a server currently throwsobj.init is not a functionbecause the instance no longer has a prototype, and the payload's keys are inherited whereObject.keyscan't see them. The same key also re-parents the merged hash inflattenProps, which then gets handed to the app's owninit(props).I put the skip in both loops rather than at the call sites since
createis the entry point everyone reaches this through, and it matches the guard_getPathalready has for the set path. Two tests increate_test.jscover it; both fail on main.