Overflow regression - #10041
Open
auvipy wants to merge 2 commits into
Open
Overflow regression#10041auvipy wants to merge 2 commits into
auvipy wants to merge 2 commits into
Conversation
Collaborator
Author
|
@jamescooke i reopened this from your branch to verify |
6 tasks
Contributor
|
Thanks @auvipy - it'd be super nice to get this closed off 馃檹馃徎 |
| ]) | ||
|
|
||
|
|
||
| class Issue7314Test(TestCase): |
Collaborator
There was a problem hiding this comment.
Suggested change
| class Issue7314Test(TestCase): | |
| class Issue7134Test(TestCase): |
Comment on lines
+1529
to
+1530
| with self.assertRaises(serializers.ValidationError): | ||
| serializer.is_valid(raise_exception=True) |
Collaborator
There was a problem hiding this comment.
Suggested change
| with self.assertRaises(serializers.ValidationError): | |
| serializer.is_valid(raise_exception=True) | |
| with self.assertRaises(serializers.ValidationError) as ctx: | |
| serializer.is_valid(raise_exception=True) | |
| # Check that the error code of the validation error | |
| self.assertEqual( | |
| [error.code for error in ctx.exception.detail['value']], | |
| ['max_value'], | |
| ) |
browniebroke
requested changes
Sep 15, 2026
browniebroke
left a comment
browniebroke
left a comment
Collaborator
There was a problem hiding this comment.
Happy to get this added yes. Noticed that the issue number is wrong and the assert on the validation error could be made a bit more specific. Suggestion added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a regression test to cover a crash that was reported a while back which has been fixed by another change in the meantime.
Closes #7134