Skip to content

fix(email): larger, selectable download-link code block in recipient email #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenhensen merged 2 commits into from
Jul 14, 2026
Merged

fix(email): larger, selectable download-link code block in recipient email #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d08192
fix(email): make recipient download link a prominent selectable code …
dobby-coder[bot] Jul 12, 2026
7c131f9
test(email): pin download-link assertion to restyled <a>
dobby-coder[bot] Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/email.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,19 @@ mod tests {
"subject: {}",
rendered.subject
);
// The download-link block must render as a prominent, selectable
// monospace code block that is not smaller than the 16px primary
// button (see issue #186). Pin a contiguous substring unique to the
// restyled `<a>` (the primary button is `display:inline-block` and not
// monospace), so a font-size regression here genuinely fails — a bare
// `font-size:16px` check would pass on the button alone.
assert!(
rendered.html.contains(
"display:block;font-family:'Courier New',Consolas,Monaco,monospace;font-size:16px;"
),
"download-link block should be a >=16px monospace code block: {}",
rendered.html
);
}

#[test]
Expand Down
6 changes: 2 additions & 4 deletions templates/email/email.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@
{{download_str}}
</a>
<div style="text-align:left;padding-top:30px;">
<p style="color:#5F7381;font-size:16px;font-weight:600;margin:0 0 4px 0;">{{link_str}}</p>
<a style="color:#3095DE;font-size:13px;font-weight:400;line-height:18px;word-break:break-all;" href="{{url}}">
{{url}}
</a>
<p style="color:#5F7381;font-size:16px;font-weight:600;margin:0 0 8px 0;">{{link_str}}</p>
<a href="{{url}}" style="display:block;font-family:'Courier New',Consolas,Monaco,monospace;font-size:16px;font-weight:600;line-height:26px;color:#030E17;background:#F2F8FD;border:1px solid #C6E2F6;border-radius:6px;padding:16px 18px;word-break:break-all;text-decoration:none;">{{url}}</a>
</div>
{% if confirm != "" %}
<div style="margin-top:30px;padding-top:20px;">
Expand Down