Skip to content

docs: add CLAUDE.md with migrated agent notes#52

Merged
rubenhensen merged 3 commits into
mainfrom
chore/add-claude-md
Jul 15, 2026
Merged

docs: add CLAUDE.md with migrated agent notes#52
rubenhensen merged 3 commits into
mainfrom
chore/add-claude-md

Conversation

@rubenhensen

@rubenhensen rubenhensen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Creates CLAUDE.md with agent notes migrated from the private dobby memory repo (encryption4all/dobby, formerly repos/<this-repo>/), verified against the current state of the code before migration. No CLAUDE.md existed on main, so this PR adds the file.

Going forward this file is the single home for durable repo knowledge: dobby updates it in the same PR whenever it learns something worth keeping.

Refs #52

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new CLAUDE.md is well-written and specific, but it has three factual-drift issues to fix before it becomes the durable knowledge home. The doc is authored as an append to a pre-existing file, but no CLAUDE.md exists on main — this PR creates it. Two claims also describe repo state that is not actually present.

  • Framing/structure: opens with an orphaned --- and no H1, as if appending.
  • release-plz.yml is described as an existing two-job workflow, but the .github/workflows/ dir has only ci.yml and pr-title.yml (release-plz.toml does exist). Confirmed against main and this branch.
  • bits() line reference has drifted (it is at src/util.rs:56 on main).

Rule check (docs-only, human-authored PR): PR title is conventional-commit compliant; prose is clean against writing-rules apart from the leading ---. No additional rule findings.

Comment thread CLAUDE.md Outdated
Comment thread CLAUDE.md Outdated
Comment thread CLAUDE.md Outdated
@rubenhensen

Copy link
Copy Markdown
Contributor Author

/dobby fix all comments you made

- Add H1 title and drop the orphaned leading '---'; this PR creates
  CLAUDE.md (no such file on main), so it is not an append.
- Drop the drift-prone src/util.rs:43-49 range for bits(); the function
  now moves on every edit, so reference the function by name instead.
- Reword the release process: release-plz.toml has landed but
  release-plz.yml is not yet present, so the automation still needs
  manual human application and the release flow is still manual.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dobby-coder dobby-coder Bot changed the title docs: extend CLAUDE.md with migrated agent notes docs: add CLAUDE.md with migrated agent notes Jul 15, 2026

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking issue in the added CLAUDE.md.

Embargo leak (blocking). The "Security: already fixed on main" section names several security-advisory identifiers in plain prose, each with its vulnerability class and fix location. Those advisories are still in draft (unpublished/embargoed) and this repo is public — merging this file would publish the advisory ids and vulnerability detail and defeat the embargo. This is the recurring draft-advisory-leak pattern.

Fix before merge: genericize that section — drop the advisory ids and the per-item vulnerability mechanism, keeping only non-sensitive facts (e.g. "several audit findings from 2026-07-04 are fixed and shipped on main; see the private advisories for detail"). Restore full detail once the advisories are published. Holding the PR in draft until then.

The three prior factual-drift findings (leading ---/framing, release-plz.yml presence, bits() line reference) are all resolved and re-verified against the repo — thanks for those.

Comment thread CLAUDE.md
@dobby-coder
dobby-coder Bot marked this pull request as draft July 15, 2026 07:21
…rgoed

The "already fixed on main" section named per-finding identifiers and their
root cause plus fix location. Those findings are still under embargo and this
repo is public, so summarize them generically and point to the private
advisories instead. Restore the detail once they are published.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@rubenhensen
rubenhensen marked this pull request as ready for review July 15, 2026 07:28
@rubenhensen
rubenhensen merged commit d0108f7 into main Jul 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant