Render branch diffs and a detail panel with field-level changes - #3
Open
andredlng wants to merge 4 commits into
Open
Render branch diffs and a detail panel with field-level changes#3andredlng wants to merge 4 commits into
andredlng wants to merge 4 commits into
Conversation
…with field diffs, init() mount API
Remove the committed build artifact under src/main/resources, the unused review-panel styles, the RelationshipChangesSection that nothing fed, the review.* locale tree and other unreferenced keys, and un-export DETAIL_PANEL_SHARE. Move diff.base under detail.diff where the code reads it, and add the detail.shared key both locales lacked. changesOnly now defaults to off; the auto-mount opts in via data-changes-only="true" and init() keeps its explicit option. init() returns an update() that merges graphData, focus, changesOnly and onSelect before re-rendering. Replace the stale sample-review.json with a fixture on the current graph contract and let index.html load it via ?sample=review.
The evidence chip is gone from the node (the detail panel still says when a change cites nothing), and the remaining warnings sit after the name with the diff word.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diff rendering for graphs served from a semantic branch, plus the detail panel that explains a change.
add | modify | removemark: coloured ring and corner badge on concept cards, chips on pill nodes, dashed coloured edges. A changes only toolbar toggle keeps changed elements and their direct neighbours.diffDetailit renders field-by-field before/after, three-way against a base when one is given, plus evidence, consumers and overlap sections when the host supplies them.init(options)entry point for hosts that fetch the graph themselves:container,graphData,changesOnly,focus,onSelect(returntrueto claim the click and suppress the built-in panel); returns{ update }. The auto-mount path is unchanged and opts into the filter withdata-changes-only="true".README.mddocuments the graph contract.Used by datamesh-manager/entropy-data (semantic change requests).