[WIP] ci/wasm: Re-enable wasm engine tests#45793
Draft
phlax wants to merge 1 commit into
Draft
Conversation
my fault - bad bash has meant these tests have been missing for a few months Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
cc @leonm1 |
jwendell
approved these changes
Jun 23, 2026
phlax
changed the title
Contributor
|
Looks like the primary issue is Is there a way to add cmake to the build image? |
Member
Author
no it needs to be made hermetic - there are examples - eg foreign_cc stuff where it uses the hermetic cmake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my fault - bad bash has meant these tests have been missing for a few months