Optimize decrefcount#45821
Open
ebm wants to merge 4 commits into
Open
Conversation
Signed-off-by: Ethan Marantz <ebmarantz@gmail.com>
Signed-off-by: Ethan Marantz <ebmarantz@gmail.com>
Signed-off-by: Ethan Marantz <ebmarantz@gmail.com>
Signed-off-by: Ethan Marantz <ebmarantz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: adds a lock free fast path to decRefCount
Additional Description: The original decRefCount holds the global allocator lock for every decrement. We needed to hold the lock to prevent a same named stat from being created at the same time as a decrement to 0. For a ref_count_ > 1, we can exercise a lock free fast path using a CAS (compare and swap) atomic operation. There are two advantages the CAS decRefCount has over the original implementation:
There is a small theoretical cost for the optimized decRefCount. When ref_count_ == 1, the CAS decRefCount needs an extra atomic relaxed load (~1 ns difference during benchmarking).
Benchmarks summary:
Full Benchmark
Testing: Passes all existing allocator tests (allocator_test.cc and thread_local_store_test.cc).
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: Should affect ARM more than x86 architectures (atomics/locking syscalls cost more with ARM).