Skip to content

Disable //test/config_test:config_test under coverage#45843

Merged
yanavlasov merged 2 commits into
envoyproxy:mainfrom
yanavlasov:coverage-1
Jun 30, 2026
Merged

Disable //test/config_test:config_test under coverage#45843
yanavlasov merged 2 commits into
envoyproxy:mainfrom
yanavlasov:coverage-1

Conversation

@yanavlasov

@yanavlasov yanavlasov commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This test links all extensions and verifies that example configs are valid. The binary is very large with coverage instrumentation and will soon fail to link due to 36Gb limit on the link artifacts in remote bazel.

The value of the test is very low as the config parsing coverage should be attained via unit or integration tests. Disabling this binary will save build resources without negative impact on useful coverage.

Risk Level: low
Testing: unit tests
Docs Changes: no
Release Notes: no
Platform Specific Features: no

Signed-off-by: Yan Avlasov <yan_avlasov@hotmail.com>
@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #45843 was opened by yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yan_avlasov@hotmail.com>
@yanavlasov yanavlasov marked this pull request as ready for review June 26, 2026 01:47
@RyanTheOptimist RyanTheOptimist self-assigned this Jun 30, 2026

@RyanTheOptimist RyanTheOptimist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you include the motivation in the PR description.

@yanavlasov yanavlasov merged commit 7be42dc into envoyproxy:main Jun 30, 2026
28 checks passed
@yanavlasov yanavlasov deleted the coverage-1 branch June 30, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants