Skip to content

chore: cswrr cleanup and e2e#8582

Merged
zirain merged 7 commits into
envoyproxy:mainfrom
jukie:cswrr-followups
Mar 31, 2026
Merged

chore: cswrr cleanup and e2e#8582
zirain merged 7 commits into
envoyproxy:mainfrom
jukie:cswrr-followups

Conversation

@jukie

@jukie jukie commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Some cleanup after merging #7407

Which issue(s) this PR fixes:

Fixes #8575

Release Notes: No

@netlify

netlify Bot commented Mar 23, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit f571377
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69cc23515e1e4e0008b5130d

@jukie jukie force-pushed the cswrr-followups branch from 9aca648 to 38d3c17 Compare March 23, 2026 16:40
@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (7a2a4ec) to head (f571377).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8582      +/-   ##
==========================================
+ Coverage   74.35%   74.38%   +0.03%     
==========================================
  Files         243      243              
  Lines       38262    38262              
==========================================
+ Hits        28450    28463      +13     
+ Misses       7818     7808      -10     
+ Partials     1994     1991       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie changed the title cleanup and e2e chore: cswrr cleanup and e2e Mar 25, 2026
@jukie jukie marked this pull request as ready for review March 25, 2026 16:33
@jukie jukie requested a review from a team as a code owner March 25, 2026 16:33
@zirain

zirain commented Mar 25, 2026

Copy link
Copy Markdown
Member

looks like all e2e tests failed.

@jukie

jukie commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

Yeah I thought metrics were the only issue, will fix

@jukie jukie marked this pull request as draft March 26, 2026 10:44
@jukie jukie force-pushed the cswrr-followups branch 3 times, most recently from 79cbf17 to 6c66115 Compare March 28, 2026 17:01
@jukie

jukie commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie jukie force-pushed the cswrr-followups branch from 6c66115 to f752c4a Compare March 31, 2026 03:32
@jukie jukie marked this pull request as ready for review March 31, 2026 04:24
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Comment thread examples/backend-utilization/.gitignore Outdated
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie jukie requested a review from a team March 31, 2026 13:08
@jukie

jukie commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@jukie jukie requested a review from zirain March 31, 2026 13:50

@arkodg arkodg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team March 31, 2026 16:01
@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Mar 31, 2026
@jukie

jukie commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@zirain zirain merged commit fdc3128 into envoyproxy:main Mar 31, 2026
39 checks passed
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
* e2e

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* test description

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* remove gitignore

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

---------

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup CSWRR implementation

3 participants