fix: exit MCP server when the client closes stdin#30
Open
den-indance wants to merge 1 commit into
Open
Conversation
The stdio transport keeps the Node event loop alive after the MCP client disconnects, so the process never exits on its own. This leaks one node process per session, and is especially acute when the server is launched via `docker exec -i`, which does not propagate the client disconnect to the in-container process. Exit cleanly when stdin emits `end`/`close`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Problem
The stdio transport keeps the Node event loop alive after the MCP client
disconnects, so the server process never exits on its own — leaking one
nodeprocess per session. Especially acute underdocker exec -i, whichdoes not propagate the client disconnect to the in-container process.
Fix
Register
end/closehandlers onprocess.stdininmain()that log asystem event and
process.exit(0).Testing
npm run typecheck— passnpm run build(tsup) — passnpm test— 33/33 passdist/index.js.