Noah Interp Flux From Coarse#3334
Open
AMLattanzi wants to merge 15 commits into
Open
Conversation
asalmgren
approved these changes
Jun 22, 2026
AMLattanzi
commented
Jun 23, 2026
…o noah vars for ML interp.
asalmgren
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For lev>0, the land surface model will interpolate the fluxes from level 0. This allows creation of a fine patch from the coarse data without a wrfinput file.
Challenges
lsm_undefined. The interpolation will pick up these values and smear them in the fine array; this effectively biases our fluxes to large values. To alleviate this issue, the surface layer now writes the iterated flux back into the noah flux data structure when an undefined value is encountered.Testing
3 3 1over thesmall domainregion.Changes
The writing of iterated fluxes into the noah structure will change regression tests because the iterated flux will now be held constant until the next noah call since it is a valid value after the overwrite. In effect, the iterations over invalid land cells will be updated at the same frequency that Noah MP is updated (rather than each step).