release: sync Cursor pstack 0.15.1 as Open Pstack 1.4.1 - #64
Conversation
|
|
Tick the box to add this pull request to the merge queue (same as
|
ericlitman
left a comment
There was a problem hiding this comment.
Gavel verdict: Request changes
1 blocking finding; 0 unconfirmed plausible findings; 0 killed by adjudication; 1 confirmed non-blocking.
Quorum: 4/3 successful reviewers.
Continuity: 1 open · 0 resolved · 0 reopened.
Scope: initial full review.
Top findings
- HIGH
UPSTREAM.md:15 RIGHTPublish the sync under a new package version —1.4.0is already the published marketplace version, and its tagged skill does not contain this rule. Claude's versioned marketplace contract only gives users updates when the marketplaceversionchanges, so an existing 1.4.0 installation that updates after this merge remains on the old skill despite this sentence claiming 1.4.0 imports 0.15.1. Publish the sync under a new Open Pstack version and update this row plus the three version-bearing manifests together.
Non-blocking findings
- LOW
UPSTREAM.md:12 RIGHTUpdate the user-facing sync records — After this row declares 0.15.1 current,README.md:156anddocs/reference.md:5still identify the distribution with 0.15.0 at71ed0d1, while the newestCHANGES.mdentry omits the 0.15.1 evidence rule. Consumers consulting those documented entry points receive contradictory provenance and behavior information. Refresh the README and reference metadata and add the corresponding change entry.
Gavel run panel:5dcf3bd87ea1f7c23e7b7ff7c7b604a8af938363:Oty01Tlz0sQ:1QLfJqCCcMw · Commit 5dcf3bd87ea1f7c23e7b7ff7c7b604a8af938363
Judge: native (primary) openai/gpt-6-astra · tools: yes
Full record: GET /gavel/run/panel:5dcf3bd87ea1f7c23e7b7ff7c7b604a8af938363:Oty01Tlz0sQ:1QLfJqCCcMw
5dcf3bd to
d932242
Compare
ericlitman
left a comment
There was a problem hiding this comment.
Gavel verdict: Request changes
1 blocking finding; 0 unconfirmed plausible findings; 0 killed by adjudication.
Quorum: 4/3 successful reviewers.
Continuity: 1 open · 0 resolved · 0 reopened.
Scope: full review (basis-not-ancestor).
Top findings
- HIGH
UPSTREAM.md:15 RIGHTPublish the skill change under a new package version — An existing 1.4.0 installation that runs the normal marketplace update after this merge will be skipped because the distribution still advertises 1.4.0, leaving that user on the old skill without the new evidence rule. This sentence documents the mismatch but does not fix the supported upgrade path. Bump the Open Pstack version and update every version-bearing manifest together.
Gavel run panel:d9322429b354de7c37b7be3471eb0d31a2536b6b:Ou6mvsvZ7fZ:D0uPJamZxS4 · Commit d9322429b354de7c37b7be3471eb0d31a2536b6b
Judge: native (primary) openai/gpt-6-astra · tools: yes
Full record: GET /gavel/run/panel:d9322429b354de7c37b7be3471eb0d31a2536b6b:Ou6mvsvZ7fZ:D0uPJamZxS4
d932242 to
bc01b4e
Compare
ericlitman
left a comment
There was a problem hiding this comment.
Gavel verdict: Approve
0 blocking findings; 0 unconfirmed plausible findings; 1 killed by adjudication.
Quorum: 4/3 successful reviewers.
Continuity: 0 open · 1 resolved · 0 reopened.
Scope: full review (basis-not-ancestor).
Top findings
No blocking findings.
Gavel run panel:bc01b4ec3f1c3d167c8843cab5bf783907885168:Fv6NYiksE44:jd6CaEcZd9g · Commit bc01b4ec3f1c3d167c8843cab5bf783907885168
Judge: native (primary) openai/gpt-6-astra · tools: yes
Full record: GET /gavel/run/panel:bc01b4ec3f1c3d167c8843cab5bf783907885168:Fv6NYiksE44:jd6CaEcZd9g
* release: sync Cursor pstack 0.15.0 as Open Pstack 1.4.0 (ericlitman#60) Open Pstack 1.4.0 syncs Cursor pstack 0.15.0 (71ed0d1). How's critique mode and the how-critics role are retired; principle-attack-the-premise and principle-test-behavior-not-implementation are added with narrow local corrections recorded in CHANGES.md. Upstream's density and punctuation passes are applied on top of the Claude Code and Codex adaptations, with the exact logo and verbatim upstream README. Closes ericlitman#61. * fix(pstack): merge lever refuses drift, empty audits, and failed binary merges (ericlitman#62) The Gavel panel review of ericlitman#60 found the upstream merge lever could overwrite work done after the audit; it now refuses to run unless HEAD is the audited commit and mapped paths are clean, reports excluded and diverged rows instead of applying them, keeps the executable bit, uses a temporary directory for merge inputs, skips the status check when nothing is mapped, and reports git merge-file failures on binaries instead of chmodding. scripts/upstream-merge-probe.py reproduces each case plus the real 0.15.0 range. Findings about repository shapes this tree does not produce were waived on the head with their disproofs. * release: sync Cursor pstack 0.15.1 as Open Pstack 1.4.1 (ericlitman#64) * fix(runner): accept Claude Code 2.1.270 JSON event array from --output-format json Claude Code 2.1.270 emits --output-format json as an array of system/assistant/result events. parseClaude required a bare result object and threw "claude emitted a non-object result", so every native-Claude probe from a Codex parent was marked malformed-output even though the model answered. Read the terminal result event from an array; keep accepting the legacy object. Fixture captured from the real CLI. --------- Co-authored-by: Eric Litman <eric@litman.org>
Closes #63
Linear: MOB-1460
What changed
Open Pstack 1.4.1 now tracks Cursor pstack 0.15.1 at f8abeddd1862dc73704e3d719dd73df0d51b8c71. The shared poteto-mode skill requires every claim to carry its evidence or an explicit measured, inferred, or guess label in the same sentence, and it tells the agent to run checks it can run instead of handing them to the user.
The three version-bearing manifests, UPSTREAM.md, README.md, docs/reference.md, CHANGES.md, and NOTICE.md now agree on Open Pstack 1.4.1 and Cursor pstack 0.15.1. No playbook, model-matrix, runtime, dependency, or package-lock content changed.
Verification
Live evidence on exact candidate commit
bc01b4ec3f1c3d167c8843cab5bf783907885168:codex plugin add pstack@open-pstack. The 1.4.1 cached poteto-mode skill matches the candidate source hash. A fresh Codex CLI session loaded that 1.4.1 skill, readUPSTREAM.md, and returnedPSTACK_0151_CODEX_OKwhile labeling the 1.4.1, pstack 0.15.1, andf8abeddclaim measured.--plugin-dir, invokedpstack:poteto-mode, readUPSTREAM.md, and returnedPSTACK_0151_CLAUDE_OKwhile labeling the same claim measured.Local validation on the same head passed with 158 Bun tests and 652 assertions, strict TypeScript checking, all four JSON manifests parsed, static package invariants passed, both Claude plugin validators passed, and
git diff --checkpassed. The fetched Cursor tree has no pstack changes afterf8abedd.The earlier Gavel package-version finding is incorporated in this head as the 1.4.1 release.