Bump plugin manifest version and guard it against drift - #5
Merged
Conversation
The Claude Code plugin manifest version sat at 0.1.1 across every release from 0.1.2 onward. `claude plugin update` only reinstalls when the manifest version rises, so it compared 0.1.1 to 0.1.1 and did nothing — no plugin or hook change (e.g. the 0.2.x automatic session-end backup hook, already present in hooks.json) could ever reach an installed machine. The CLI version is CI-checked against the git tag, but the plugin manifest was a separate string with nothing watching it. Bump both manifests (plugin.json and marketplace.json) to the package version, and add tests/test_plugin_manifest.py asserting they equal __version__ so a release that forgets the plugin bump fails CI. Document the three-place bump in RELEASING.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NnaQwZUSDRbVUNh8fsdksD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (found on the work laptop)
The Claude Code plugin manifest version was stuck at
0.1.1in bothintegrations/claude-code/.claude-plugin/plugin.jsonand.claude-plugin/marketplace.json— across every release from 0.1.2 onward.claude plugin updateonly reinstalls when the manifest version rises, so it compared 0.1.1 to 0.1.1 and correctly did nothing. Result: no plugin or hook change could reach an installed machine — including the automatic session-end backup hook (memware backup --if-stale 20 --quiet) that's been inhooks.jsonsince 0.2.x.The CLI version is CI-enforced against the git tag (
release.yml), but the plugin manifest was a separate, unchecked string — which is exactly why it silently drifted for six releases.Fix
0.2.4).tests/test_plugin_manifest.pyassertingplugin.jsonand the marketplace entry both equalmemware.__version__, so a release that forgets the plugin bump now fails CI.RELEASING.md.No package code changed, so no new PyPI release is needed — the plugin is served from
main. After merge, installed machines get the current hooks with:Full suite, ruff, ruff format, mypy green locally.
🤖 Generated with Claude Code