Fix: completions test must not require the optional shtab extra - #9
Merged
Conversation
The release job verifies the bare wheel (no [shell] extra), so shtab isn't installed and `completions` returns exit 2 with an install hint. A test must not require an optional dependency: accept the script (exit 0) when shtab is present and the hint (exit 2) when it isn't. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NnaQwZUSDRbVUNh8fsdksD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.0 release build failed here:
The release job verifies against the bare wheel (no
[shell]extra), soshtabis absent andmemware completionscorrectly returns exit 2 with an install hint. The test wrongly required the optional dependency. Now it accepts either outcome: the completion script (exit 0) when shtab is installed, or the hint (exit 2) when it isn't. Matrix CI (which installs[dev], incl. shtab) still exercises the real script path.No version change — after this merges I'll re-tag
v0.3.0(nothing was published; the build failed before the publish step).🤖 Generated with Claude Code