refactor(renderer): trim RenderContext dead quad/shader resources (RC5 cleanup)#47
Merged
Merged
Conversation
…RC5 cleanup) The quad VAO and color/texture/extMesh shaders RenderContext created were only ever consumed by the retired Renderer class (deleted in #45) — getQuadVAO/ getColorShader/getTextureShader/getExtMeshShader have zero callers now. Remove those members, their getters, and initQuadData/initShaders. init() now creates only the white texture (its sole live resource), dropping three unused shader compilations and a VAO/VBO/IBO allocation from every App's startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dead-code cleanup following the legacy-renderer retirement (#45). The quad VAO and color/texture/extMesh shaders
RenderContextcreated were only ever used by the retiredRendererclass —getQuadVAO/getColorShader/getTextureShader/getExtMeshShadernow have zero callers.initQuadData/initShaders.RenderContext::init()now creates only the white texture (its sole live resource), dropping three unused shader compilations + a VAO/VBO/IBO allocation from every App's startup.Net −86 lines. Verified: no remaining references to the removed symbols.
Remaining RC5 (optional refinements — assessed)
Shader::bind()sites (PostProcess, ShapePlugin, GeometryBindings, RenderFrame) still route through the device rather than the tracker. This is cache-coherence purity, not a live bug —StateTracker::reset()each frame sets the cache to 0 and the main path runs before PostProcess, so no wrong dedup occurs. Completing it means injecting StateTracker into PostProcess.collect()clearsChunkData.dirty(amutablecontent-side flag). The clean fix is a generation counter inChunkData(TilemapSystem change) so the plugin detects rebuilds read-only — orthogonal to the renderer/GfxDevice work.