Skip to content

fix: preserve parsing error locations in Bun #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumirlumir wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

fix: preserve parsing error locations in Bun #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d982da
fix: preserve parsing error locations in Bun
lumirlumir Sep 5, 2026
31f3f2c
wip
lumirlumir Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/languages/json-language.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ export class JSONLanguage {
errors: [
{
...ex,
line: ex.line,
column: ex.column,
message,
},
],
Expand Down
6 changes: 6 additions & 0 deletions tests/languages/json-language.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ describe("JSONLanguage", () => {
result.errors[0].message,
"Unexpected character '/' found.",
);
assert.strictEqual(result.errors[0].line, 2);
assert.strictEqual(result.errors[0].column, 1);
});

it("should not parse trailing commas by default in json mode", () => {
Expand All @@ -99,6 +101,8 @@ describe("JSONLanguage", () => {
result.errors[0].message,
"Unexpected token RBrace found.",
);
assert.strictEqual(result.errors[0].line, 3);
assert.strictEqual(result.errors[0].column, 1);
});

it("should not parse trailing commas by default in jsonc mode", () => {
Expand All @@ -113,6 +117,8 @@ describe("JSONLanguage", () => {
result.errors[0].message,
"Unexpected token RBrace found.",
);
assert.strictEqual(result.errors[0].line, 3);
assert.strictEqual(result.errors[0].column, 1);
});

it("should parse trailing commas when enabled in jsonc mode", () => {
Expand Down