feat(tests): EIP-8037 - no refill for failed creates onto alive accounts - #3529
Merged
LouisTsai-Csie merged 1 commit intoSep 22, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3529 +/- ##
================================================
Coverage 94.49% 94.49%
================================================
Files 624 624
Lines 36964 36964
Branches 3331 3331
================================================
Hits 34930 34930
Misses 1435 1435
Partials 599 599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
tests/amsterdam/eip-8037-closeout
branch
2 times, most recently
from
September 4, 2026 13:59
96d5d17 to
d261b09
Compare
spencer-tb
marked this pull request as ready for review
September 21, 2026 13:14
Add a regression test proving that a create frame failing on an alive destination refills no NEW_ACCOUNT state gas: the factory's gas is tuned so its probe SSTORE only fits when the reservoir funds it, and removing the refill guard fails all twelve no_reservoir fixtures. Correct the collision-test docstring (an alive target is never charged, so nothing is refunded) and record the EELS line-coverage evidence for the checklist: every EIP-8037 line is executed, with the remaining misses classified as pre-existing code.
spencer-tb
force-pushed
the
tests/amsterdam/eip-8037-closeout
branch
from
September 21, 2026 14:15
d261b09 to
3f01d32
Compare
LouisTsai-Csie
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close out the EIP-8037 testing-checklist evidence.
NEW_ACCOUNTstate gas. The factory's gas is tuned so its probe SSTORE only fits when the reservoir funds it; making the refill ingeneric_createunconditional fails all twelveno_reservoirfixtures and none of the twelvereservoir_coversones.general/code_coverage/eelsandmissed_lines). Filling the directory (2179 fixtures) executes every EIP-8037 line; the misses in the touched files are pre-existing branches, classified ineip_checklist_external_coverage.txt. The top-frameNEW_ACCOUNTcharge for a value transfer to a non-alive recipient is exercised by the EIP-2780 directory.The reference pin was refreshed to the current
eip-8037.mdblob by #3582, so this PR no longer touchesspec.py.uv run checklist --eip 8037reports 28/29 on this branch (26/29 onforks/amsterdam); the remaining item issecond_client.Related Issues or PRs
Part of #3217; follows #3478, #3524, #3525 and #3582.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.