Skip to content

feat(tests): cover block state budget after authorization preparation rollback - #3540

Merged
LouisTsai-Csie merged 4 commits into
ethereum:forks/amsterdamfrom
spencer-tb:tests/amsterdam/auth-preparation-block-budget
Sep 22, 2026
Merged

LouisTsai-Csie merged 4 commits into
ethereum:forks/amsterdamfrom
spencer-tb:tests/amsterdam/auth-preparation-block-budget

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

Pin that authorization state gas rolled back on preparation failure leaves the block state budget, admitting a following transaction at exact fit and rejecting it one gas over. Existing preparation tests check receipts and post-state without block admission, while dispatch-failure block tests cover authorizations that persist.

Related Issues or PRs

#3217 (EIP-8037 section); ethereum/EIPs#12303 (merged 2026-09-14).

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

A curious kitten

@codecov

codecov Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.49%. Comparing base (d4c28bf) to head (28dfccc).
⚠️ Report is 10 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3540      +/-   ##
===================================================
+ Coverage            94.47%   94.49%   +0.02%     
===================================================
  Files                  624      624              
  Lines                36969    36964       -5     
  Branches              3334     3331       -3     
===================================================
+ Hits                 34925    34930       +5     
+ Misses                1443     1435       -8     
+ Partials               601      599       -2     
Flag Coverage Δ
unittests 94.49% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb
spencer-tb force-pushed the tests/amsterdam/auth-preparation-block-budget branch from 4da6b82 to b3fbfd3 Compare September 18, 2026 10:27
@spencer-tb spencer-tb changed the title test(tests): cover block state budget after authorization preparation rollback feat(tests): cover block state budget after authorization preparation rollback Sep 18, 2026
@spencer-tb
spencer-tb marked this pull request as ready for review September 18, 2026 10:27
@LouisTsai-Csie
LouisTsai-Csie self-requested a review September 21, 2026 08:37

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create a PR on top of this one for some readability, logic remains the same, please let me know what you think: spencer-tb#65

@LouisTsai-Csie LouisTsai-Csie added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels Sep 22, 2026
@LouisTsai-Csie
LouisTsai-Csie merged commit 0a53ad8 into ethereum:forks/amsterdam Sep 22, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants