Conversation
…ceipt status (cherry picked from commit b07128d)
spencer-tb
approved these changes
Sep 15, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! cc-ing @LouisTsai-Csie for merge, maybe it was missed or there was a reason to not include it :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3585 +/- ##
================================================
Coverage 94.44% 94.44%
================================================
Files 624 624
Lines 36927 36929 +2
Branches 3326 3326
================================================
+ Hits 34874 34876 +2
Misses 1450 1450
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is @spencer-tb's fix from his review on #3349, cherry-picked as he suggested in the issue, authorship kept. Each tx now carries the deepest depth its budget can fund and the fill asserts every receipt is status 1, so an OOG mid descent fails the fill instead of passing silently.
Filled
test_nested_frame_memoryon Amsterdam at 100M. Before the change, the 64K/256 case fills with receipt status 0 if you add the assertion. After it, all nine cases pass. At mem 0 and 8K every tx still descends the full 256 frames. At 64K the 16,777,216 tx cap only funds 175 frames, so the clamp takes 256 down to 175 there, which is the point of the change rather than a gap in it.Related Issues or PRs
Closes #3547
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.