fix(test-cli): render coverage on repeated checklist rows - #3586
Merged
danceratopz merged 1 commit intoSep 15, 2026
Merged
danceratopz merged 1 commit into
danceratopz merged 1 commit into
Conversation
danceratopz
added
C-bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3586 +/- ##
================================================
Coverage 94.44% 94.44%
================================================
Files 624 624
Lines 36929 36929
Branches 3326 3326
================================================
Hits 34876 34876
Misses 1450 1450
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
approved these changes
Sep 15, 2026
The template describes invalid and valid data-floor transactions with the same checklist ID. The item map keeps one entry per ID, and the old renderer only updated that entry's last line. A report could therefore show 100% coverage while leaving the first outcome visibly blank. Render each template row using its ID's shared evidence while preserving that row's description. Keep summary counts based on unique IDs. Add a regression for test, external and N/A evidence that fails before the fix and checks both rows without double-counting the item. Validation: all 10 checklist consistency and renderer tests and just static pass on the isolated branch. This changes reporting, not consensus fixtures.
danceratopz
force-pushed
the
fix-checklist-repeated-rows
branch
from
September 15, 2026 09:34
aebcd50 to
8b3971c
Compare
danceratopz
marked this pull request as ready for review
September 15, 2026 09:45
danceratopz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a checklist ID appears on multiple template rows, the report currently fills only its last row. The summary can therefore show full coverage while an earlier row remains blank.
Render coverage on every matching row, preserving each description and counting the ID once. Add regression tests for test evidence, external evidence, and N/A declarations.
Discovered while doing the 7981 checklist.
Validation: all 10 checklist tests and
just staticpass.Related Issues or PRs
Extracted from #3537. Related to #3217 and #1943.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.