Conversation
Fold Call50000_ecrec and static_Call50000_ecrec into a single parametrized test over every call opcode, with ten iterations instead of fifty thousand. The fillers repeat the call until the transaction runs out of gas, so their whole post-state is the empty one a reverted transaction leaves behind; running the loop to completion instead lets the residue be checked. What the precompile receives, stipend included, is exactly one gas short of its price, so every call fails: the success flags accumulate to their seeded base, the loop counter proves all ten iterations ran, the seeded return word survives and the precompile receives no value. One gas more and every call recovers instead. The input window stays as wide as the fillers made it, far wider than the 128 bytes the precompile reads.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3590 +/- ##
===================================================
- Coverage 94.44% 94.44% -0.01%
===================================================
Files 624 624
Lines 36929 36928 -1
Branches 3326 3326
===================================================
- Hits 34876 34875 -1
Misses 1450 1450
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
self-requested a review
September 16, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fold Call50000_ecrec and static_Call50000_ecrec into a single parametrized test over every call opcode, with ten iterations instead of fifty thousand. The fillers repeat the call until the transaction runs out of gas, so their whole post-state is the empty one a reverted transaction leaves behind; running the loop to completion instead lets the residue be checked.
What the precompile receives, stipend included, is exactly one gas short of its price, so every call fails: the success flags accumulate to their seeded base, the loop counter proves all ten iterations ran, the seeded return word survives and the precompile receives no value. One gas more and every call recovers instead. The input window stays as wide as the fillers made it, far wider than the 128 bytes the precompile reads.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.